<div dir="auto">Thanks, I'll go over the links! </div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Jul 16, 2022, 15:54 Andreas Pirklbauer <<a href="mailto:andreas_pirklbauer@yahoo.com">andreas_pirklbauer@yahoo.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Luca,<br>
<br>
See my inline answers below:<br>
<br>
> Luca Boasso luke.boasso at <a href="http://gmail.com" rel="noreferrer noreferrer" target="_blank">gmail.com</a> Sat Jul 16 20:22:54 CEST 2022<br>
><br>
> Hi Andreas, <br>
> <br>
> Thanks for giving that a try!<br>
> <br>
> Is this approach over all simpler than the one I am using in oberonc? It is hard for me to say since your solution evolved over time, but you should be able to give your take since you knew about the Griesemer's approach.<br>
<br>
Yes, my approach is considerably (!) simpler than oberonc and Griesemer’s approach.. in the sense that I found a way to do away with module anchors and global module tables completely. If on <a href="http://github.com/andreaspirklbauer/Oberon-module-imports" rel="noreferrer noreferrer" target="_blank">http://github.com/andreaspirklbauer/Oberon-module-imports</a> you scroll down to section 6., the approach is briefly explained (I essentially propagate the reference number of each re-exported type through the module hierarchy and then use that number to detect whether a type has already been re-imported or not).<br>
<br>
> Do you have a comprehensive test suite I could try with oberonc to see if both compilers agree on the result? <br>
<br>
I have now added (essentially your) test suite here: <br>
<br>
<a href="https://github.com/andreaspirklbauer/Oberon-module-imports/tree/master/Sources/TestImport" rel="noreferrer noreferrer" target="_blank">https://github.com/andreaspirklbauer/Oberon-module-imports/tree/master/Sources/TestImport</a><br>
<br>
There is a file called TESTIMPORT.Tool which contains a single ORP.Compile command that compiles the test suite.<br>
<br>
All module compile correctly except for 3 cases, which I intentionally disallow (I don’t allow creating more than one alias per imported module or importing the same module twice, finally PO 2013 doesn’t allow external pointer base types - I restriction which I just inherited and didn’t want to touch).<br>
<br>
I could easily allow those cases as well, but then I would need to change the symbol table data structure in topScope. This seemed unnecessary.<br>
<br>
For further reading on the rationale used and a proof that indeed all possible cases are covered by it, see:<br>
<br>
<a href="https://github.com/andreaspirklbauer/Oberon-module-imports/blob/master/Documentation/Allowing-reimports-to-coexist-with-module-aliases-and-identifiers.md" rel="noreferrer noreferrer" target="_blank">https://github.com/andreaspirklbauer/Oberon-module-imports/blob/master/Documentation/Allowing-reimports-to-coexist-with-module-aliases-and-identifiers.md</a><br>
<br>
as well as the test file<br>
<br>
<a href="https://github.com/andreaspirklbauer/Oberon-module-imports/blob/master/Sources/TestImport/TestImport.Mod" rel="noreferrer noreferrer" target="_blank">https://github.com/andreaspirklbauer/Oberon-module-imports/blob/master/Sources/TestImport/TestImport.Mod</a><br>
<br>
You can just click through the various modules contained in this file. They really cover all possible cases. This is comforting to know.<br>
<br>
> Cheers, Luca<br>
<br>
Cheers,<br>
Andreas<br>
<br>
> > On Sat, Jul 16, 2022, 09:52 Andreas Pirklbauer <andreas_pirklbauer at <a href="http://yahoo.com" rel="noreferrer noreferrer" target="_blank">yahoo.com</a>> wrote: > > Luca Boasso luke.boasso at <a href="http://gmail.com" rel="noreferrer noreferrer" target="_blank">gmail.com</a> Sun May 16 03:13:24 CEST 2021 <br>
> > <br>
> > I have two problems in forcing the programmer to think about import <br>
> ordering: <br>
> > <br>
> > 1. It does not scale. If you have big systems it is hard to hold in your <br>
> > head all the import relationships. It is better to have the compiler <br>
> figure <br>
> > it out for you and do the proper checks. <br>
> > <br>
> > 2. It breaks encapsulation. If I (module B) import a module A, I should <br>
> > only care about its public interface, not how it is implemented. So if <br>
> the <br>
> > module A re-imports types and indirectly could mess with the import <br>
> > order of my module B, we have implementation details leaking through. <br>
> > So when the implementation changes the import order of the client <br>
> > modules could break. <br>
><br>
> Luca, <br>
><br>
> I now couldn’t resist and have actually implemented a variant <br>
> of ORB that removes the “invalid import order” restriction and <br>
> allows hidden re-imports to peacefully coexist with identifiers. <br>
><br>
> It was surprisingly straight-forward to implement, only about <br>
> 15-20 lines of code. Details are here (variant 2): <br>
><br>
> <a href="https://github.com/andreaspirklbauer/Oberon-module-imports" rel="noreferrer noreferrer" target="_blank">https://github.com/andreaspirklbauer/Oberon-module-imports</a><br>
><br>
> The key idea is to simply propagate reference numbers of <br>
> re-exported types from the original module throughout the <br>
> module hierarchy (I just add to the information that is <br>
> already output for re-exported types). When later a <br>
> type T is imported explicitly, one only needs to check <br>
> that particular reference number had previously been <br>
> re-imported. And if so, the type is discarded after <br>
> having read it from the symbol file. <br>
><br>
> PS: This would make a nice exercise for a compiler course. <br>
> Not much to code, but some thinking is required for sure. <br>
><br>
> Andreas<br>
<br>
--<br>
<a href="mailto:Oberon@lists.inf.ethz.ch" target="_blank" rel="noreferrer">Oberon@lists.inf.ethz.ch</a> mailing list for ETH Oberon and related systems<br>
<a href="https://lists.inf.ethz.ch/mailman/listinfo/oberon" rel="noreferrer noreferrer" target="_blank">https://lists.inf.ethz.ch/mailman/listinfo/oberon</a><br>
</blockquote></div>