[Barrelfish-users] Hake lost a dependency

[Kornilios Kourtis]

Hi,

On Fri, Mar 29, 2013 at 05:26:01PM +0800, Wang Nan wrote:
> Hi,
> 
> I can't compile barrelfish before I add a dependency in RuleDefs.hs.
> 
> In generated Makefile, "./x86_64/kernel/arch/x86/misc.o" doesn't depend
> on "x86_64/include/trace_definitions/trace_defs.h", but uses it by
> including trace/trace.h.
> 
> So I suggest the following patch:
> 
> diff -r f82a7cbc7224 hake/RuleDefs.hs
> --- a/hake/RuleDefs.hs Wed Mar 20 18:29:06 2013 +0100
> +++ b/hake/RuleDefs.hs Fri Mar 29 17:24:14 2013 +0800
> @@ -134,6 +134,7 @@
> optIncludes = kernelIncludes arch,
> optDependencies =
> [ Dep InstallTree arch "/include/errors/errno.h",
> + Dep InstallTree arch "/include/trace_definitions/trace_defs.h",
> Dep InstallTree arch "/include/barrelfish_kpi/capbits.h",
> Dep InstallTree arch "/include/asmoffsets.h" ],
> optLdFlags = kernelLdFlags arch,

Thanks a lot for the patch!

I believe this issue was also mentioned in another mail to the list, so
we will make sure that it's part of our next release.

cheers,
Kornilios.

-- 
Kornilios Kourtis